mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 122 forks source link

Pin occt to novtk build variant #37588

Closed thomashampson closed 1 week ago

thomashampson commented 1 week ago

Description of work

Specify the novtk build of occt. Otherwise vtk is installed as an occt dependency. This then brings in a lot of other dependencies and adds a lot of unnecessary bloat. One of the packages that is installed is qt6-main, which has caused problems on some Windows machines when attempting to launch workbench from a Conda install (see attached issue). Removing the vtk dependency should resolve that issue.

Fixes #37581.

To test:

Once this build https://builds.mantidproject.org/job/build_packages_from_branch/823 has finished, the conda packages should be available on our conda channel. Create a new env and install with

mamba create -n novtk_test
mamba activate novtk_test
mamba install -c mantid/label/occt_novtk_test mantidworkbench
  1. Verify that the novtk version of occt is installed in the conda environment (use the conda list to display all installed packages)
  2. Also check that vtk and qt6-main are not in the environment.

This does not require release notes because it's a packaging change that won't directly affect users


Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.