Reverts the changes made in #36674 because the plugin dll directory only gets added to the path for the bundled package, and not for the conda package on Windows. Because the Indirect plugin dll depends on the Inelastic plugin dll, we therefore need to store the Inelastic plugin dll in the Library dll directory.
This is a temporary measure for this release. We want to extract the common functionality in both Inelastic and Indirect plugin libraries, and put this into a non-plugin library. We can then get the Inelastic and Indirect plugin libraries to depend on this new library, and the Inelastic plugin library can then be installed in the plugin directory as we were previously doing.
See the following issue to do this follow-up work: #37591
Install mantidworkbench into a new Conda env, as above.
Check no DLL errors
Check Indirect and Inelastic interface categories exist
Install and open a bundled Mantid from the build packages from branch
Check no DLL errors
Check Indirect and Inelastic interface categories exist
This does not require release notes because no user-facing changes
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
Reverts the changes made in #36674 because the plugin dll directory only gets added to the path for the bundled package, and not for the conda package on Windows. Because the Indirect plugin dll depends on the Inelastic plugin dll, we therefore need to store the Inelastic plugin dll in the Library dll directory.
This is a temporary measure for this release. We want to extract the common functionality in both Inelastic and Indirect plugin libraries, and put this into a non-plugin library. We can then get the Inelastic and Indirect plugin libraries to depend on this new library, and the Inelastic plugin library can then be installed in the plugin directory as we were previously doing.
See the following issue to do this follow-up work: #37591
Fixes #37587
To test:
When this job has finished https://builds.mantidproject.org/job/build_packages_from_branch/821/ The Windows packages should be installable by
mamba install -c mantid/label/indirect_dll_fix mantidworkbench
On Windows:
mantidworkbench
into a new Conda env, as above.This does not require release notes because no user-facing changes
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.