search

mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 122 forks source link

Move common Inelastic/Indirect functionality into separate library #37591

Open robertapplin opened 1 week ago

robertapplin commented 1 week ago

Describe the outcome that is desired. The common functionality used in both the MantidScientificInterfacesIndirectQt5 and MantidScientificInterfacesInelasticQt5 plugin libraries should be moved into a separate non-plugin library so that the Indirect plugin library no longer needs to depend on the Inelastic plugin library. The MantidScientificInterfacesIndirectQt5 and MantidScientificInterfacesInelasticQt5 plugin libraries should then depend on the new common library.

When this is done, the MantidScientificInterfacesInelasticQt5 plugin library should then be installed into the plugin directory on this line https://github.com/mantidproject/mantid/blob/90736331232a1ca4e603ca8dd17d6a7a176a4f1c/qt/scientific_interfaces/Inelastic/CMakeLists.txt#L38

(See the Indirect CMakeLists to see what this line should be)

Additional context A temporary measure was implemented in #37590 for the release of v6.10.