mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 122 forks source link

Fix unresponsive plot sliders on Moments tab #37595

Closed adriazalvarez closed 4 days ago

adriazalvarez commented 1 week ago

Description of work

This PR fixes a bug where the sliders of the Moments tab in the Data Processor interface were not responding to changes in the property browser. Additionally, I have done a small bit of refactoring of the Moments Presenter class and move the validator to the presenter instead of the view, as well as adding some unit tests for the presenter.

Summary of work

Fixes #37428.

Further detail of work

To test:

Added release notes


Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

github-actions[bot] commented 5 days ago

:wave: Hi, @adriazalvarez,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.