This PR pins scipy <1.14 because of the following error appearing in our CI:
ERROR: test_interpolation_change (NMoldyn4InterpolationTest.NMoldyn4InterpolationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "c:\jenkins_workdir\workspace\pull_requests-conda-windows\framework\pythoninterface\mantid\simpleapi.py", line 1083, in __call__
algm.execute()
RuntimeError: `interp2d` has been removed in SciPy 1.14.0.
This pin is temporary so that we can get the release out the door. We will unpin the max version of scipy in a future PR and fix instances that are struggling with the recent scipy changes. See this issue https://github.com/mantidproject/mantid/issues/37605
To test:
Make sure the tests pass, in particular the NMoldyn4InterpolationTest.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
This PR pins scipy <1.14 because of the following error appearing in our CI:
This pin is temporary so that we can get the release out the door. We will unpin the max version of scipy in a future PR and fix instances that are struggling with the recent scipy changes. See this issue https://github.com/mantidproject/mantid/issues/37605
To test:
Make sure the tests pass, in particular the
NMoldyn4InterpolationTest.Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.