Closed robertapplin closed 3 days ago
I just noticed that if I go to the DensityOfStates tab and click
Run
with nothing selected Mantid closes with an unhandled exception
Thanks for spotting that! It looks like a bug thats been around for a long time - I've added better validation to prevent this
Description of work
This PR ensures the new RunWidget is used in the Indirect Simulations interface.
Part of #37381
To test:
Interfaces->Indirect->Simulations
Without loading data, click "Run". A validation message should appear. The Run button should remain enabled.
Load the data below for the relevant tab
Click Run and wait. When running, the Run button should be disabled and say "Running..."
When Running has finished, the Run button should be re-enabled
Click Plot or Plot Result in the output options to make sure external plots appear.
MolDyn: Input File: NaF_DISF.zip FunctionNames:
Sqw-Na
Sassena: No data could be found as this is a largely unused tab - so ignore this tab
DensitiesOfStates: Input File: csd_benzen11_PhonDisp.zip
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.