mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 122 forks source link

Fix typos in SXD documentation #37615

Closed GuiMacielPereira closed 4 days ago

GuiMacielPereira commented 4 days ago

Description of work

Fixed some typos so that scripts run successfully.

To test:

Copy fixed scripts and check that they run without errors


Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

GuiMacielPereira commented 4 days ago

I just noticed there is a conflict so I'll resolve it

GuiMacielPereira commented 4 days ago

Can you check that L176 should come before L177?

RichardWaiteSTFC commented 4 days ago

Can you check that L176 should come before L177?

Yes agreed, that's the best order now the other PR got merged, there's no need to calculate tbar for peaks we throw away!