mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 121 forks source link

Remove References to the ADS from HeliumAnalyserEfficiency Algorithm #37626

Open cailafinn opened 4 days ago

cailafinn commented 4 days ago

Describe the outcome that is desired. The algorithm currently queries the ADS to access the input properties. We would prefer it didn't do this as it would force any workflow algorithms to make use of the ADS internally during processing.

Describe any solutions you are considering Correct assignment to a type (such as MatrixWorkspace_sptr will cast the property to that type. Only a nullptr check is required.

Additional context As little contact with the ADS should be performed as possible. Running tests with the algorithm acting as a Child should probably be added as well.