mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 121 forks source link

Update cppcheck to 2.14.2 #37631

Closed thomashampson closed 1 day ago

thomashampson commented 3 days ago

Description of work

Update to the latest version of cppcheck on conda-forge.

Purpose of work

Major benefits:

Fixes #37462

To test:


Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

jclarkeSTFC commented 2 days ago

I've been through all the errors and checked if they were there before, there are three that are new/different:

But none of the code has changed so whatever those things are is how they were before anyway.