This PR removes duplicate code from the Data Reduction interface and ensures it uses the new RunWidget. It also removes the setup(), validate() and run() functions from all remaining tab classes because we no longer require to use them. We also do not require runTab and validateTab.
Having the RunWidget will allow us to work on two new features detailed by #37418 and #37201 . It allows us to easily roll out these new features to all tabs in the Indirect and Inelastic interfaces.
Fixes #37381
To do
[x] Remove instances of runTab()
[x] Remove instances of setup(), validate() and run()
[x] Wait for Tools RunWidget PR to be merged then rebase
This does not require release notes because it is a maintenance change
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
This PR removes duplicate code from the Data Reduction interface and ensures it uses the new RunWidget. It also removes the
setup()
,validate()
andrun()
functions from all remaining tab classes because we no longer require to use them. We also do not requirerunTab
andvalidateTab
.Having the RunWidget will allow us to work on two new features detailed by #37418 and #37201 . It allows us to easily roll out these new features to all tabs in the Indirect and Inelastic interfaces.
Fixes #37381
To do
runTab()
setup()
,validate()
andrun()
To test:
Follow the testing instructions on this page https://developer.mantidproject.org/Testing/Indirect/DataReductionTests.html
This does not require release notes because it is a maintenance change
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.