mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
209 stars 122 forks source link

Manual Testing Sample Transmission calculator #37993

Open MohamedAlmaki opened 2 days ago

MohamedAlmaki commented 2 days ago

You have been assigned manual testing. The hope is to catch as many problems with the code before release, so it would be great if you can take some time to give a serious test to your assigned area. Thank you!!

The general guide to manual testing:

Specific Notes:

Make sure that inputs and outputs work sensibly, stress test with some bad inputs (e.g. letters in a numeric input) See https://developer.mantidproject.org/Testing/General/SampleTransmissionCalculatorTestGuide.html

RichardWaiteSTFC commented 9 hours ago

In single wavelength spin boxes you can use , which is ignored but should not be able to type it

RichardWaiteSTFC commented 9 hours ago

Entering just spaces in the chemical formula throws unexpected exception on linux conda, IDAaaS and windows

Traceback (most recent call last):
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\SampleTransmissionCalculator\stc_presenter.py", line 30, in calculate
    output = self.model.calculate(input_dict)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\SampleTransmissionCalculator\stc_model.py", line 22, in calculate
    transmission_ws = CalculateSampleTransmission(
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantid\simpleapi.py", line 1082, in __call__
    set_properties(algm, *args, **final_keywords)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantid\simpleapi.py", line 971, in set_properties
    do_set_property(key, value)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantid\simpleapi.py", line 954, in do_set_property
    raise e.__class__(msg) from e
ValueError: Problem setting "ChemicalFormula" in CalculateSampleTransmission-v1: Invalid value for property ChemicalFormula (string) from string "          ": When setting value of property "ChemicalFormula": A value must be entered for this parameter

This is not a regression - seen on v6.10

cailafinn commented 9 hours ago

Entering just spaces in the chemical formula throws unexpected exception on linux conda, IDAaaS and windows

Traceback (most recent call last):
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\SampleTransmissionCalculator\stc_presenter.py", line 30, in calculate
    output = self.model.calculate(input_dict)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\SampleTransmissionCalculator\stc_model.py", line 22, in calculate
    transmission_ws = CalculateSampleTransmission(
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantid\simpleapi.py", line 1082, in __call__
    set_properties(algm, *args, **final_keywords)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantid\simpleapi.py", line 971, in set_properties
    do_set_property(key, value)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantid\simpleapi.py", line 954, in do_set_property
    raise e.__class__(msg) from e
ValueError: Problem setting "ChemicalFormula" in CalculateSampleTransmission-v1: Invalid value for property ChemicalFormula (string) from string "          ": When setting value of property "ChemicalFormula": A value must be entered for this parameter

This is not a regression - seen on v6.10

Issue here

yusufjimoh commented 7 hours ago

irs26176_graphite002_QLr_Prob-1

irs26176_graphite002_QLr_Result-1

Screenshot from 2024-09-19 16-58-07

Two of the sub-output plots in the Inelastic BayeFitting, under both the Quasi and Stretch tabs, appear to have incorrect labels. Specifically, two items are suffixed with '_result' rather than their actual plot names. For instance, on the Quasi tab, the first plot, 'prob,' is correctly labelled as 'datasetname_prob.' However, 'Amplitude' and 'FWHM' are labelled as 'datasetname_result,' when they should likely be 'datasetname_amplitude' and 'datasetname_FWHM,' respectively

https://developer.mantidproject.org/Testing/Inelastic/BayesFittingTests.html