mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
211 stars 124 forks source link

Manual Testing ISIS Reflectometry #37994

Closed MohamedAlmaki closed 1 month ago

MohamedAlmaki commented 1 month ago

You have been assigned manual testing. The hope is to catch as many problems with the code before release, so it would be great if you can take some time to give a serious test to your assigned area. Thank you!!

The general guide to manual testing:

Specific Notes:

http://developer.mantidproject.org/Testing/ReflectometryGUI/ReflectometryGUITests.html

RichardWaiteSTFC commented 1 month ago
  1. Load Batch File Test > Not clear what/where Expand group button is - perhaps a picture would help?
  2. Add/Delete Batch Test > Deleting all batch tabs, new one opens but keeps iterating number
MohamedAlmaki commented 1 month ago

I got a crash when trying to change the polarization correction option in the experiment settings from FilePath to ParameterFile. We couldn't reproduce again so it might be just a random crash. Just a note that there were multiple load plugin failures in the stack trace but nothing related to the reflectometry interface

adriazalvarez commented 1 month ago

In search by experiment instructions: Whenever you try to transfer runs to the runs table, if there is an empty group on the table, the transferred run won't override this empty group but be placed in a row under the empty group. Additionally, if you have added 2 or 3 groups to the table, then you add an empty group, and then you transfer more runs, the empty group will stay there in the table. Empty groups should disappear when transferring data.

adriazalvarez commented 1 month ago

When changing data on a run row (for example the angle). it adds a new empty row just below after finishing the edit.

adriazalvarez commented 1 month ago

There are many (long) instructions, particularly in the last sections of the manual test. It would be helpful for following the instructions to have them numbered.

adriazalvarez commented 1 month ago

On the preview tab instructions, the following instruction doesn't match the results on the test, there is no ReflectometryISISSumBanks property on the history of the workspace:

Right-click the workspace and select Show History:
    In the Algorithms list, expand ReflectometryISISLoadAndProcess.
    Click on ReflectometryReductionOneAuto and check in the right hand pane that the inputs for ProcessingInstructions, BackgroundProcessingInstructions and TransmissionProcessingInstructions correspond to the ranges of spectra you selected.
    Expand ReflectometryReductionOneAuto.
    Click on ReflectometryISISSumBanks and check that the input for ROIDetectorIDs matches the range of detector IDs you selected.
adriazalvarez commented 1 month ago

Finish time: 90 mins.