Both SofQWCentre and SofQWPolygon are replaced by SofQWNormalisedPolygon and should get removed, eventually. According to the usage database, they are not in use anymore, but there might be uses that are not registered in the database. This PR adds a deprecation warning for both to give potential users a warning that these algorithms will get removed in a few releases.
There is no associated issue.
To test:
Call SofQWCentre and SofQWPolygon and check that the deprecation warning is displayed.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
Summary of work
Both
SofQWCentreandSofQWPolygonare replaced bySofQWNormalisedPolygonand should get removed, eventually. According to the usage database, they are not in use anymore, but there might be uses that are not registered in the database. This PR adds a deprecation warning for both to give potential users a warning that these algorithms will get removed in a few releases.There is no associated issue.
To test:
Call
SofQWCentreandSofQWPolygonand check that the deprecation warning is displayed.Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.