Remove deprecated Calculate Paalman Pings tab from Inelastic Corrections

robertapplin commented 1 week ago

Description of work

This PR removes the deprecated Calculate Paalman Pings tab from the Inelastic Corrections interface. This tab has been supersceded by the Calculate Monte Carlo Absorption tab. The Calculate Paalman Pings tab has been deprecated for the last two stable releases, and there has been no contact from users saying that they want to keep this, so its being removed to ensure we only keep code that is being used.

Fixes #36365

To test:

Open Inelastic->Corrections interface
There should be three tabs only (and no tab called "Calculate Paalman Pings"
Follow the corrections testing instructions here: https://developer.mantidproject.org/Testing/Inelastic/CorrectionsTests.html

Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Is the code of an acceptable quality?
Does the code conform to the coding standards?
Are the unit tests small and test the class in isolation?
If there is GUI work does it follow the GUI standards?
If there are changes in the release notes then do they describe the changes appropriately?
Do the release notes conform to the release notes guide?

Functional Tests

Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

SilkeSchomann commented 1 week ago

The manual testing instructions https://developer.mantidproject.org/Testing/Inelastic/CorrectionsTests.html still have a section for Calculate Paalman Pings Tab. I think this section should just get removed.

robertapplin commented 1 week ago

The manual testing instructions https://developer.mantidproject.org/Testing/Inelastic/CorrectionsTests.html still have a section for Calculate Paalman Pings Tab. I think this section should just get removed.

I believe this has been removed in the "Files changed", but we don't see this in the live documentation page which comes from the nightly

mantidproject / mantid