The issue is explained in #38204 : parameters for exponential correction were not being correctly retrieved when in autodetect mode, as the instrument parameters were being retrieved as string, but in the case of the exponential parameters, these are better retrieved as numbers. On the other hand, the polynomial parameters have the flexibility of being input as a double list or string with comma separated values for the parameters.
Additional changes:
I have re-set the value of the correction parameters in the calling algorithm ReflectometryReductionOneAuto.
I have added two tests to check that the correction parameters are being properly called in AutoDetect mode both for exponential corrections and polynomial corrections.
Summary of work
Fixes #38204
Further detail of work
To test:
Follow testing instructions on #38204 and make sure that the parameters are properly set by looking at the history.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
The issue is explained in #38204 : parameters for exponential correction were not being correctly retrieved when in autodetect mode, as the instrument parameters were being retrieved as string, but in the case of the exponential parameters, these are better retrieved as numbers. On the other hand, the polynomial parameters have the flexibility of being input as a double list or string with comma separated values for the parameters.
Additional changes:
ReflectometryReductionOneAuto.AutoDetectmode both for exponential corrections and polynomial corrections.Summary of work
Fixes #38204
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.