Putting several ranges as inputs to LoadVesuvio was causing Mantid to crash.
It is now fixed so that input can handle several ranges specified.
Summary of work
Allow for inputs to have several commas and several ranges.
Purpose of work
This issue was reported by a Vesuvio instrument scientist, and should get fixed.
Report to: Anna Marsicano
To test:
Run the script
from mantid.simpleapi import *
LoadVesuvio(Filename='43066-43070, 43072-43074', SpectrumList='144-182', Mode='SingleDifference', InstrumentParFile='/home/ljg28444/.mvesuvio/ip_files/ip2018_3.par', OutputWorkspace='ws')
with the path to this instrument file (unzip it):
ip2018_3.zip
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
Putting several ranges as inputs to LoadVesuvio was causing Mantid to crash. It is now fixed so that input can handle several ranges specified.
Summary of work
Allow for inputs to have several commas and several ranges.
Purpose of work
This issue was reported by a Vesuvio instrument scientist, and should get fixed.
Report to: Anna Marsicano
To test:
Run the script
with the path to this instrument file (unzip it): ip2018_3.zip
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.