mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
210 stars 122 forks source link

FilterEvents has wrong log values #8304

Closed AndreiSavici closed 9 years ago

AndreiSavici commented 11 years ago

I tried to run the following script

Load(Filename=r'/SNS/ARCS/2012_2_18_CAL/data/ARCS_30489_event.nxs',OutputWorkspace='ARCS_30489_event',LoadMonitors='1')
GenerateEventsFilter(InputWorkspace='ARCS_30489_event',OutputWorkspace='f',InformationWorkspace='fi',UnitOfTime='Nanoseconds',LogName='CCR12Rot',MinimumLogValue='-50',MaximumLogValue='-20',LogValueInterval='1',FilterLogValueByChangingDirection='Decrease')
FilterEvents(InputWorkspace='ARCS_30489_event',OutputWorkspaceBaseName='filtered',InformationWorkspace='fi',SplitterWorkspace='f',FilterByPulseTime='1',GroupWorkspaces='1')
  1. I expect that in workspace 1 to have events from CCR12Rot=-49 to -48. I get events from -49.5 to -48.5. The documentation needs to be changed. Or the algorithm should do as expected
  2. The more problematic is the first (sometimes the last - depending on direction) workspace. In workspace 0 I expect to see data from -50.5 to -49.5 (in the current way of handling this), but the lower limit is -65.2. I am not sure if the events are filtered correctly, but I am sure that the log values are not
AndreiSavici commented 9 years ago

This issue was originally trac ticket 7459