search

mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
10 stars 6 forks source link

Qt-material theme bug fix #2217

Closed MikeSullivan7 closed 3 weeks ago

MikeSullivan7 commented 1 month ago

Issue

Closes #2209.

Description

When the Theme in the settings menu is changed to Fusion, the Stylesheet of the QApplication is reset correctly. The UI bugs were caused by the qt-material function apply_stylesheet changing the applications stylesheet and those changes persisting once the theme was changed back to Fusion.

Acceptance Criteria

Repeat the changes in the linked issue and check that the themes look as expected:

  1. Start Mantid Imaging
  2. Select File > Settings
  3. Select an alternative theme to Fusion
  4. Restart mantid Imaging
  5. Select File > Settings
  6. Select "Use OS Default"

Also change any and all combinations of settings in the Appearance Settings tab to check they are behaving correctly. MI should also correctly store and apply the last given settings upon startup.

Example screenshots are given here:

My default OS settings (I use dark mode!)

image

changing to a qt-material theme:

image

restarting MI and clicking the Use OS defaults checkbox:

image

Documentation

Release Note

coveralls commented 1 month ago

Coverage Status

coverage: 72.721% (-0.01%) from 72.735% when pulling 992c49212d3443934fb10e8aa8658ad9abc2609b on 2209_qt_material_theme_bug_fixes into 4d2ef3e3620992889e30eec29d520001605500aa on main.

JackEAllen commented 1 month ago

I can give this a secondary review on Monday if not merged in by then having found the original issue 🙂