search

mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
13 stars 6 forks source link

Spectrum viewer: use QFormLayout to layout ToF labels and widgets #2226

Closed samtygier-stfc closed 3 months ago

samtygier-stfc commented 3 months ago

Issue

Closes #2225

Description

Use QFormLayout to layout ToF labels and widgets

Previously the QGroupBox had no layout set, so the widgets just used absolute positioning.

Testing

The screenshot tests should pick up the change and prevent regressions

Acceptance Criteria

Open the spectrum viewer, check that all the labels in the left column are visible

Documentation

Not needed (small fix for something that is new in the release)

samtygier-stfc commented 3 months ago

This needs an update to the applitools baselines. But the applitools website is not displaying images for me correctly, so will try later.

samtygier-stfc commented 3 months ago

Changes from applitools: image

Causes some small position shifts for everything in the spectrum window

samtygier-stfc commented 3 months ago

I have make new baselines for the spectrum window tests.

coveralls commented 3 months ago

Coverage Status

coverage: 72.705%. remained the same when pulling 5ded79176bdc2979d23a8129ebad18cef4c9fd57 on 2225-fix-labels into 06f179e795d048342469aed93f20079de8850511 on main.