mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
10 stars 6 forks source link

Refactor Codebase by Removing Obsolete Functionality due to Introducing Efficient Compute Functions #2229

Open ashmeigh opened 3 weeks ago

ashmeigh commented 3 weeks ago

Description

This pull request proposes the removal of specific functions and a type alias from our project that have become redundant due to the introduction of more modern and efficient compute functions. This change aims to enhance system performance and code maintainability.

Functions Removed

Testing

Extensive testing has confirmed that these changes do not negatively impact our operations. All tests have been updated to align with the new system, ensuring that it performs reliably and efficiently.

Acceptance Criteria

  1. Run Unit Tests: Ensure that all existing unit tests pass successfully. This includes tests that have been updated to reflect the removal of the deprecated functions.
  2. Integration Testing: Perform integration tests to verify that the new compute functions interact correctly with other parts of the system.
  3. Performance Benchmarking: Compare the performance of the new compute functions with the old functions to ensure that there are improvements or at least no regressions.
  4. Manual Testing: Conduct manual testing on critical workflows that previously relied on the removed functions to confirm they operate as expected.

Documentation

The documentation has been updated to reflect these changes. All relevant modifications have been documented in the appropriate file in docs/release_notes.

coveralls commented 6 days ago

Coverage Status

coverage: 73.154% (+0.02%) from 73.137% when pulling 1b3d63c3e4d7dc5e63535f5245312e2ad06ade79 on remove_shared_functions into dce729e5147779ad642d6b053017acdc4c9dc560 on main.

coveralls commented 4 days ago

Coverage Status

coverage: 73.16% (+0.02%) from 73.137% when pulling b638feb30e1ba32d7552a204b271ccb34c20a070 on remove_shared_functions into dce729e5147779ad642d6b053017acdc4c9dc560 on main.