Closed JackEAllen closed 3 months ago
This PR changes the spectrum viewer GUI and therefore I have updated the screenshot test baselines
A small thing if its easy to fix.
The fix might be to uncheck the shuttercount check box when it is disabled.
A small thing if its easy to fix.
- With a dataset that does not have shutter counts
- Open spectrum viewer, check "Normalise to open beam" and set norm stack
- Check "ShutterCount Correction", the error should now be displayed
- Change the Norm stack to the sample, this should the error for the norm to open beam, hides the shuttercount error, disables the shuttercount checkbox.
- Change the Norm stack back to the open beam
- Now the shutter count check box is enabled and checked, but not showing the error message.
The fix might be to uncheck the shuttercount check box when it is disabled.
Thanks for noticing this one, yeah, easy to fix, just uncheck if disabled within handle_button_enabled
Looking good. I've gone through steps on the issue plus some extra playing around.
Thanks for the thorough review 👍
Issue
Closes #2230
Description
Add a description of the changes made.
Modify Spectrum Viewer to add toggle interface for ShutterCount normalisation correction and warning icon when ShutterCount correction is toggled on, ShutterCount stacks are not loaded.
Testing
Describe the tests that were used to verify your changes.
Acceptance Criteria
How should the reviewer test your changes?
Documentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes
docs/release_notes/next/feature-2230-ShutterCount_Correction_CheckBox