search

mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
10 stars 6 forks source link

Spectrum Viewer type checking #2237

Closed samtygier-stfc closed 1 week ago

samtygier-stfc commented 1 week ago

Issue

Some type checking for #2213

Description

Type checking in Spectrum viewer in the model

Reduces untyped lines in mantidimaging.gui.windows.spectrum_viewer.model from 17.35% to 14.75%.

Acceptance Criteria

Tests should all pass. Check that moving ROIs with the spin boxes still works. Have a play with the spectrum viewer

Documentation

Not needed

coveralls commented 1 week ago

Coverage Status

coverage: 73.156%. remained the same when pulling e76e18b399dca7d900c37b6d8d707395422e3de4 on 2213-type-checking into d40724317a710baf2d6eaf64da7ae71adc810e14 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 73.156%. remained the same when pulling 559b0f081c2936a014ef7ca8c83062e8aa7ad8b8 on 2213-type-checking into d40724317a710baf2d6eaf64da7ae71adc810e14 on main.