search

mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
13 stars 6 forks source link

Unify datasets part 1 #2288

Closed samtygier-stfc closed 2 months ago

samtygier-stfc commented 2 months ago

Issue

Work on #2199

Description

This is the first step in unifying MixedDataset and StrictDataset. This first step moves all the implementation of MixedDataset into BaseDataset.

This required some changes that result in a small changes to the rest of the codebase Forcing constructor arguments to named, because the current classes use different argument ordering Forcing access to the recons through a property.

Testing

I have moved the MixedDataset and StrictDataset tests into core. I have added a DatasetTest, currently for BaseDataset. This will duplicate tests from the other test classes, and eventually replace them. I have left the MixedDataset and StrictDataset alone (apart from small API changes), to ensure that the classes behaviour is not changed.

Acceptance Criteria

Test loading a dataset and an image stack

Documentation

Not needed yet

coveralls commented 2 months ago

Coverage Status

coverage: 73.09% (-0.03%) from 73.115% when pulling cf7bf35470c7dd5d5a748d2633c96faa3a51021e on 2199-unify-datasets-1 into 8cf298f64c1250c94898f3e8982fdf48c3dfb9f2 on main.

samtygier-stfc commented 2 months ago

I think its all going to get a bunch more testing over the next few PRs, so I'd suggest merging now