search

mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
13 stars 6 forks source link

Fix numpy deprecation warnings #2290

Closed MikeSullivan7 closed 2 months ago

MikeSullivan7 commented 2 months ago

Issue

Closes #2289. Requires PR #2280

Description

As we are upgrading the version of Numpy, a few of the other dependencies start showing DeprecationWarnings leading up to Numpy 1.25.0 and 2.0. Some of the dependencies have been updated to a point where these changes have been dealt with by the authors of our dependancies.

Testing

make check make test-system

Acceptance Criteria

Make sure that you can rebuild the dev env with no installation or dependency conflicts. Run all tests and make sure that no DeprecationWarnings show for Numpy, an example of which can be seen in the linked issue #2289. Ensure that MI runs as normal!

Documentation

Will add release note

MikeSullivan7 commented 2 months ago

NOTE: I will rebase this once PR #2280 is merged

coveralls commented 2 months ago

Coverage Status

coverage: 73.069%. remained the same when pulling 004069e2404433a91826c07e55e7362f3197c429 on 2289_fix_numpy_deprecation_warnings into 45416e779fcbcbf38490c8bdeab786a90bfaf529 on main.