2285 Crop Coordinates Operation Window: Restrict ROI MaxBounds and Handle Dialog Window Closure

JackEAllen commented 2 months ago

Issue

Closes #2285

Description

Add a description of the changes made.

Prevent ROI from extending outside of Image stack bounds
Resolve dialog window closure persistence on parent, operations window closure.

Testing

Describe the tests that were used to verify your changes.

Update tests to reflect changes made to use image stack size in ROI initialiser instead of fixed values of 200
Manually tested trying to get ROI to be larger than image stack bounds
Self-validated no error messages are present post applying crop to stack and all stacks
Self-validated that closing the operations window when the crop-coordinates dialog window is open, also closes dialog crop-coordinate dialog window

Acceptance Criteria

How should the reviewer test your changes?

No ROI warning post crop
ROI can't be resized larger than image stack
ROI does not initialise post crop on a second crop outside ROI bounds
ROI dialog window closes if the parent operations window is closed
Tests pass

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

docs/release_notes/next/fix-2285-crop-coord-stack-bounds

coveralls commented 2 months ago

coverage: 74.301% (-0.02%) from 74.316% when pulling b074c81e084b4881cb9f2c0aa3b43069ae01ab6a on 2285_crop_coord_stack_bounds into 79a43a1d0a4ad1969b3ff778254a2312dfe49082 on main.

samtygier-stfc commented 1 month ago

Also in mantidimaging/gui/test/gui_system_operations_test.py can 'Error applying filter for preview... be removed from ALLOWED_ERRORS now?

samtygier-stfc commented 1 month ago

All working well. Looks good.

mantidproject / mantidimaging