search

mantidproject / mantidimaging

Graphical toolkit for neutron imaging.
https://mantidproject.github.io/mantidimaging
GNU General Public License v3.0
13 stars 6 forks source link

Fix nexus save #2405

Closed samtygier-stfc closed 4 days ago

samtygier-stfc commented 1 week ago

Issue

Closes #2404

Description

Async tasks need to return something, because the None looks like a failed task. Add a test so that this would have been caught. Make the test_save_images able to catch the equivalent issue Make load and save fails raise an exception rather than just open a dialog, so that problems are easier for the tests to catch. This means the test_failed_attempt_to_load_shows_error and test_failed_attempt_to_save_shows_error tests now test for an exception.

Testing

A new test and updates to others

Acceptance Criteria

Check that you can save a nexus file without errors. Remove the return True from do_nexus_saving() and check that you still get an error dialog and the the system tests (make test-system) catch the problem.

Documentation

Release notes

coveralls commented 1 week ago

Coverage Status

coverage: 74.222% (-0.005%) from 74.227% when pulling 9dd000d00dea9bbee2655cc0ca7c36b21e5224d1 on 2402-fix-nexus-save into e027cbbef1750f556e5c40f6389d5432a6ccb34e on main.