search

mantidproject / mslice

Source code for Mantid MSlice
http://mantidproject.github.io/mslice
1 stars 2 forks source link

Stop storing GDOS cuts in ADS #925

Closed MialLewis closed 1 year ago

MialLewis commented 1 year ago

Description of work:

Currently, when correcting cuts with GDOS, the result is stored in the ADS. This PR corrects that.

To test:

1) Load MAR21335_Ei60meV dataset 2) Take a cut 3) Correct for GDOS 4) In the console run: from mantid.api import AnalysisDataService as ADS; ADS.getObjectNames() 5) See no objects stored in ADS.

robertapplin commented 1 year ago

Is it ok that these are the only workspaces in the ADS?

from mantid.api import AnalysisDataService as ADS; ADS.getObjectNames()
Out[1]: 
['__MSL_|Q|',
 '__MSLMAR21335_Ei60meV',
 '__MSLMAR21335_Ei60meV_cut(-2.000,2.000)']
MialLewis commented 1 year ago

Is it ok that these are the only workspaces in the ADS?

from mantid.api import AnalysisDataService as ADS; ADS.getObjectNames()
Out[1]: 
['__MSL_|Q|',
 '__MSLMAR21335_Ei60meV',
 '__MSLMAR21335_Ei60meV_cut(-2.000,2.000)']

When I follow the test steps on this branch I get: from mantid.api import AnalysisDataService as ADS; ADS.getObjectNames() Out[1]: []

When I follow the test steps on main I get: from mantid.api import AnalysisDataService as ADS; ADS.getObjectNames() Out[1]: ['MAR21335_Ei60meV_cut(-5.000,5.000)MAR21335_Ei60meV_cut(-5.000,5.000)']

I'm not sure why you can see those workspaces... prehaps as they're prepended __ they're hidden from me for some reason. Could you retest, if they persist I'll look into them>

robertapplin commented 1 year ago

I'm not sure why you can see those workspaces... prehaps as they're prepended __ they're hidden from me for some reason. Could you retest, if they persist I'll look into them>

I might be taking the cut wrong, how are you doing the cut?

MialLewis commented 1 year ago

I'm not sure why you can see those workspaces... prehaps as they're prepended __ they're hidden from me for some reason. Could you retest, if they persist I'll look into them>

I might be taking the cut wrong, how are you doing the cut?

Just loading the data, and taking a cut directly from the data (I'm not taking a slice first).

robertapplin commented 1 year ago

Just loading the data, and taking a cut directly from the data (I'm not taking a slice first).

Do you have "Show invisible workspaces" on in the mantid settings? The workspace names beginning with __ usually mean they are hidden. I think that your PR has worked because I don't see any non-hidden workspaces in the ADS

MialLewis commented 1 year ago

I guess that's the `

Just loading the data, and taking a cut directly from the data (I'm not taking a slice first).

Do you have "Show invisible workspaces" on in the mantid settings? The workspace names beginning with __ usually mean they are hidden. I think that your PR has worked because I don't see any non-hidden workspaces in the ADS

I guess that's the some reason I was looking for above. After toggling that I see the same as you, so we're good to go.