search

mantidproject / mslice

Source code for Mantid MSlice
http://mantidproject.github.io/mslice
1 stars 1 forks source link

Fix for empty mdhisto lines #987

Closed SilkeSchomann closed 1 month ago

SilkeSchomann commented 1 month ago

Description of work: When the intensity of a cut is changed to GDOS, a two-dimensional MDHisto workspace is created. When converting this to a matrix workspace, the bin size needs to be calculated on base of the second dimension, not the first. I have also added an error message in case a one-dimensional workspace or the second dimension does not have the correct size. This check is now also covered by a unit test.

To test:

Follow the instructions in the original issue: https://github.com/mantidproject/mslice/issues/986 In addition, please also check that the following problem does not re-occur: https://github.com/mantidproject/mslice/issues/972

Fixes #986.

SilkeSchomann commented 1 month ago

@adriazalvarez The release notes for MSlice are added when the SHA for MSlice is updated in Mantid. The release note infrastructure in Mantid cannot pick up release notes from the MSlice repo easily.

I have opened a GitHub issue for the problem after deleting a workspace: https://github.com/mantidproject/mslice/issues/988

adriazalvarez commented 1 month ago

Ah, I see. 😅 Thanks for letting me know.