flagpack gradient and shadow?

mantinedev / mantine-flagpack

4x3 country flags as React components, based on flagpack

https://mantinedev.github.io/mantine-flagpack

MIT License

46 stars 5 forks source link

flagpack gradient and shadow? #2

Open Geczy opened 1 year ago

Geczy commented 1 year ago

how do we take advantage of the original flagpack options?

https://flagpack.xyz/docs/design/#styles

https://www.npmjs.com/package/react-flagpack

hoping for all props to become available

rtivital commented 1 year ago

It is not planned to introduce these features as they might increase bundle size significantly or mess up with tree-shaking

Geczy commented 1 year ago

why would it increase bundle size or mess up tree shaking? these are just css classes

see here https://github.com/Yummygum/react-flagpack/blob/main/src/Flag.scss#L100

and usage here https://github.com/Yummygum/react-flagpack/blob/main/src/Flag.tsx#L27

Geczy commented 1 year ago

@rtivital any update?

rtivital commented 1 year ago

I'm not planning to work on this any time soon. If you want this feature, you are welcome to submit a PR. Note that you will need to test that tree shacking works.