mantinedev / mantine

A fully featured React components library
https://mantine.dev
MIT License
26.87k stars 1.9k forks source link

[Feature Request] Add rounded cap option to `RingProgress` #397

Closed csandman closed 2 years ago

csandman commented 3 years ago

For the package RingProgress from @mantine/core, it would be nice to have a capIsRound prop to round the ends of the progress bar. Chakra UI has a similar option in their CircularProgress component:

rtivital commented 3 years ago

Thanks for proposal! We will try things out and see if it works as expected for multiple sections

rtivital commented 3 years ago

I've tried out strokeLinecap="round" like in Chakra and it does not seem to work well with multiple sections, leaving this issue for community to solve.

amithkk commented 2 years ago

When multiple sections are involved, which one of the following is the the expected look for the progress-circle? (See Below)

1. 1

2. 2

rtivital commented 2 years ago

@amithkk the first one

amithkk commented 2 years ago

In that case I think I'll pick this up and raise a pull request when done since I need it for a personal project I'm working on anyway.

rtivital commented 2 years ago

Okay, thanks!

rtivital commented 2 years ago

PR is merged, feature will be available with next minor release 3.5

rtivital commented 2 years ago

Added in 3.5.0