search

mantinedev / ui.mantine.dev

Mantine UI website and components
https://ui.mantine.dev
MIT License
2.84k stars 314 forks source link

Typo: Currency sign is not prefixing the value amount #93

Closed fagro-vizcaino closed 4 months ago

fagro-vizcaino commented 4 months ago

Tiny typo, the currency sign is not prefixing the amount

https://github.com/mantinedev/ui.mantine.dev/blob/8be56fdda5b7697f7448187f1c4750a8514af16a/lib/CarouselCard/CarouselCard.tsx#L58

ryeviz commented 4 months ago
$397

/by adding the '$' sign before the amount, the price will be displayed with the currency sign as a prefix./

fagro-vizcaino commented 4 months ago

Hi @ryeviz

Do you mean to use a component like NumberFormatter for the prefix? Or do you mean that it's ok the way it's displayed?

image
ryeviz commented 4 months ago

Hello @fagro-vizcaino Just add the currency sign before the amount

$397
fagro-vizcaino commented 4 months ago

Sure, that's what I did on this PR to fix that example. @ryeviz

https://github.com/mantinedev/ui.mantine.dev/pull/94/commits/a285bdc298c9779d72e851d58307e12cfca26a4b