search

mantisbt-plugins / LinkedCustomFields

MantisBT plugin allowing custom fields to be linked, creating linked drop-downs
GNU General Public License v2.0
6 stars 11 forks source link

Bug fix when source or target custom field values are added or deleted #2

Closed scalastic closed 3 years ago

scalastic commented 9 years ago

Modify the array’s index build so that it is now possible to add custom values wherever you want in your source and target custom fields without loosing all your previous registered links. The array’s indexes are now build with the values themselves and no longer the array’index number which was causing wrong links when custom fields values were added or deleted.

rombert commented 9 years ago

Thanks for the submission! Can you give me some simple steps to reproduce the problem that this PR fixes?

scalastic commented 9 years ago

Links two custom fields and add a value in the middle of the source one. All your linked are translated by one from the added source value : the source index has changed but not the linked target one. Build the source index with the source values fields prevent this behaviour.

dregad commented 9 years ago

@rombert please note that @scalastic's commit is changing file modes from 644 to 755.

scalastic commented 9 years ago

Oups ! Sorry :( I will push regular web files permissions tonight.

scalastic commented 9 years ago

Hi @rombert , Files permissions are changed by the github client desktop itself.
I've seen that you changed the column 's size table. Great ! That was one of the necessary and painless changes to operate on this usefull plugin. Are you going to merge my PR by the way ? Does it need some changes ?

rombert commented 9 years ago

@scalastic - was waiting for an upload without the mode changes. I'll take a look at this in the next couple of days.