CasN
commented
6 months ago @dregad, without that change I am getting the following error: DEPRECATED 'Creation of dynamic property ADORecordSet_mysqli::$adodbFetchMode is deprecated' in '/var/www/html/mantistest/vendor/adodb/adodb-php/drivers/adodb-mysqli.inc.php' line 930 Please use the "Back" button in your web browser to return to the previous page. There you can correct whatever problems were identified in this error or select another action. You can also click an option from the menu bar to go directly to a new section. While researching what to do ,I found a link which suggested this change. And it works for me (indeed running php 8.2) Hope this clarifies it. In case there is a better option, let me know. Kind regards, Cas
From: Damien Regad @.> Sent: Tuesday, 14 May 2024 13:34 To: mantisbt-plugins/Query @.> Cc: Cas Nuy @.>; State change @.> Subject: Re: [mantisbt-plugins/Query] Update README.MD (PR #4)
@dregad commented on this pull request.
In README.MDhttps://github.com/mantisbt-plugins/Query/pull/4#discussion_r1599864591:
+
+When using PHP 8.2 or later, a change is required to vendor/adodb/adodb-php/drivers/adodb-mysqli.inc.php.
+Find the following lines
+
+```
+/*--------------------------------------------------------------------------------------
- Class Name: Recordset
+--------------------------------------------------------------------------------------*/
+class ADORecordSet_mysqli extends ADORecordSet{
+```
+and make it look like this:
+```
+/*--------------------------------------------------------------------------------------
- Class Name: Recordset
+--------------------------------------------------------------------------------------*/
+#[AllowDynamicProperties]
Can you please explain why this is necessary ?
It seems strange to me, that you would need to add custom properties to the ADOdb RecordSet object, which is normally abstracted behind the MantisBT database API.
— Reply to this email directly, view it on GitHubhttps://github.com/mantisbt-plugins/Query/pull/4#pullrequestreview-2055087278, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYLFFD7XKEXWW3JIEAGF5DZCHZDXAVCNFSM6AAAAABHUJNNU2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGA4DOMRXHA. You are receiving this because you modified the open/close state.Message ID: @.**@.>>
dregad
Add structure (titles/subtitles)
Fix Markdown formatting, typos.
About requirements section: I set 2.0.0 per the plugin's register() method, but probably a more recent version is required.