search

mantisbt-plugins / source-integration

Source control integration plugin framework for MantisBT, including support for Github, Gitlab, Bitbucket, Gitea, Gitweb, Cgit, Subversion, Mercurial and more
http://noswap.com/projects/source-integration/
MIT License
181 stars 130 forks source link

Various GitLab improvements (files, better retrieval of trees, import_limit, faster overview, regex for filtering branches, ...) #342

Closed being-peace closed 2 years ago

being-peace commented 4 years ago
dregad commented 4 years ago

@being-peace many thanks for your contribution.

If it's not too much effort, I would greatly appreciate if you could split your commit into atomic changes (i.e. each one of the above bullet points should be a distinct commit).

Also, considering that the SourceGithub plugin has a very similar code base (Gitlab was initially created as a clone of it), it would be great to see of some or all of your proposed enhancements, could also apply to it.

being-peace commented 4 years ago

Puh, of course, atomic changes would be cleaner, but indeed, it's quite an effort. I don't know, when I find time for this. Technically, it would mean creating new pull requests for each of the contributions? Or is there a different way?

Regarding GitHub, there are things that I could add (add regexp or list filtering of branches), but others (in most importantly, the files) are already in GitHub.

dregad commented 4 years ago

atomic changes would be cleaner, but indeed, it's quite an effort

Grouped changes makes the review / testing process more difficult and time-consuming for me (and I don't have a lot of spare time :wink: ).

It can remain a single pull request with multiple commits submitted from a single feature branch, or split into several PR's as you prefer, it makes no difference for me. Note: this is where logging Issues separately can be useful, as you can reference issues in the commit message (e.g. Fixes #xxx) and when the PR is merged, all corresponding issues will be closed automatically.

If it's too much work I could merge as-is of course, but please keep in mind to make atomic commits in the future.

Regarding GitHub, there are things that I could add (add regexp or list filtering of branches), but others (in most importantly, the files) are already in GitHub.

Thanks for looking into it.

being-peace commented 3 years ago

@dregad Thanks for having a look, the comments and submitting the "file count" seperately. You are definitely right with your comments.

I would like to find some time to resolve the other things, but I cannot promise... :-(

dregad commented 3 years ago

OK, thanks. Take your time :smiley:

dregad commented 2 years ago

@being-peace considering it's been almost a year without activity, and the PR has conflicts, I'm going to close it for now. Feel free to reopen after rebasing your branch, or create a new PR if and when you're ready.