search

mantl / mesos-consul

Mesos to Consul bridge for service discovery
Apache License 2.0
338 stars 95 forks source link

Adds per-container-ip detection. #21

Closed cheuschober closed 8 years ago

cheuschober commented 8 years ago

Hi. This pull request adds per-container IP detection similar to the way provided by mesos-dns which is a necessary feature for such networking models as Calico.

Port number discovery is currently not functioning since no labels have yet been designated for service ports as have been for Container IP's.

Also applied go fmt.

ChrisAubuchon commented 8 years ago

What version of Mesos are you running that has the ip labels in the task status? mesos-consul is currently targets 0.22.1

I have a 0.3 branch that I would like to add this to instead of merging into master.

cheuschober commented 8 years ago

We're running a custom 0.24-ish mesos and a custom 0.11-ish marathon. This is all in service of shoehorning calico-docker into mesos to enable per-container-ip's. Feel free to suggest pointing this at whatever branch you feel is most appropriate. I have a few other ideas down the road for mesos-consul enhancements (and a pretty dedicated professional investment) but thought it'd be worthwhile to just open the dialogue sooner rather than later.

stevendborrelli commented 8 years ago

@cheuschober by any chance are you at MesosCon? I'd love to talk.

cheuschober commented 8 years ago

@stevendborrelli Absolutely! If you're here as well I'd love to meet.

cheuschober commented 8 years ago

Closing and retargeting for 0.3