search

mantl / mesos-consul

Mesos to Consul bridge for service discovery
Apache License 2.0
338 stars 95 forks source link

Add multi-failure check before removing register #48

Closed bryanstephens closed 8 years ago

bryanstephens commented 8 years ago

Adding a flag to be able to specify a number of failed checks before mesos-consul removes the task from consul.

The motivation behind this change is because we had observed that mesos-consul was removing running tasks from consul when the leader mesos-master was down during the poll for running tasks. This would lead to our load balancer getting reconfigured to have no services for a significant period of time. The idea behind this solution is to configure the number of times mesos-consul should tolerate not finding the registered task in the mesos-master leader state before de-registering it from Consul.

ChrisAubuchon commented 8 years ago

Merged. Thanks!

bryanstephens commented 8 years ago

Awesome thanks! Your comment made my day lol.

bryanstephens commented 8 years ago

@ChrisAubuchon Just curious, when is another build going to be be cut for this project? We would like to utilize an official release build in our code but we can certainly run off of a local build if it isn't ready.

ChrisAubuchon commented 8 years ago

0.4 will probably be released after the whitelist branch is merged.