search

mantl / mesos-consul

Mesos to Consul bridge for service discovery
Apache License 2.0
338 stars 95 forks source link

Stale services in Consul #54

Closed scalp42 closed 8 years ago

scalp42 commented 8 years ago

After multiple deployments, I have a single service running in Marathon:

But unfortunately, Consul has some stale info in it:

The only app per Marathon should be running on 31263 but you can see that Consul is populated with some old tasks:

Any ideas ?

Thanks a lot in advance!

ChrisAubuchon commented 8 years ago

Check fix/service-cleanup branch. The wrong address was being used at deregistration

scalp42 commented 8 years ago

@ChrisAubuchon thanks a lot for the help!! Do you know if there'll be a master branch with both branches merged in ? (Trying to figure if we could do without forking)

ChrisAubuchon commented 8 years ago

There will be. Can you test the fix/service-cleanup branch and let me know if it fixes your issue? If it does I'll merge it in.

scalp42 commented 8 years ago

Do you know by any chance how to pull the branch with go get (without forking) ?

Going to fork for now to get this going.

ChrisAubuchon commented 8 years ago

I would run git clone -b fix/service-cleanup https://github.com/CiscoCloud/mesos-consul instead of go get

scalp42 commented 8 years ago 
/opt/go/src/github.com/scalp42/mesos-consul/main.go:73: c.ServiceName undefined (type *config.Config has no field or method ServiceName)
/opt/go/src/github.com/scalp42/mesos-consul/main.go:74: c.ServiceTags undefined (type *config.Config has no field or method ServiceTags)
ChrisAubuchon commented 8 years ago

I merged it to master. You should be able to go get it now

scalp42 commented 8 years ago

Okay gonna try right now, give me 20 mins to rinse/repeat tasks.

scalp42 commented 8 years ago

Looks good! Thanks @ChrisAubuchon