mantl / mesos-consul

Mesos to Consul bridge for service discovery
Apache License 2.0
338 stars 95 forks source link

Fix deregistration #59

Closed jfindley closed 8 years ago

jfindley commented 8 years ago

Fixes a bug in deregistration, where the process aborts if a single deregistration fails. This happens most commonly if a host is down, and means that any deregistrations after those on the downed host will not be performed.

This PR changes that behaviour so that a message will be thrown if a deregistration request fails (at info level) but degregistration will continue.

miry commented 8 years ago

I found this bug very harmful. My consul has a invalid keys. And now dns discovery is not working well, because pointed to old instances instead of varnish old key. I think to add verify how many instances per task do you have in marathon.

Can @owners of the repo merge this fix?

ChrisAubuchon commented 8 years ago

Implemented in https://github.com/CiscoCloud/mesos-consul/commit/af1ce097d8d121b765b267c41a5db2fa5023ab68