mantl / mesos-consul

Mesos to Consul bridge for service discovery
Apache License 2.0
338 stars 95 forks source link

add blacklist option #66

Closed atongen closed 8 years ago

atongen commented 8 years ago

We had the same issue as was originally reported in https://github.com/CiscoCloud/mesos-consul/issues/45 with the request for a whitelisting feature (spark tasks), however, in our case a blacklist was more appropriate since we want mesos-consul to register the majority of tasks, and filter out only a few of them.

While it's possible to construct a "negative regex" and use that in the whitelist argument, it's clunky and not something regexes are particularly good at. A blacklist option is cleaner for this.

This pull request provides a blacklist option that is essentially the same as the whitelist implementation, but with opposite logic.

ChrisAubuchon commented 8 years ago

Looks good! Thanks!