mantl / mesos-consul

Mesos to Consul bridge for service discovery
Apache License 2.0
338 stars 95 forks source link

Remove default health-check ip #99

Closed ernestas-poskus closed 6 years ago

ernestas-poskus commented 7 years ago

@ChrisAubuchon @atongen @erSitzt

This makes health check server to listen on all network interfaces. I had problem since default ip is localhost or lo interface running mesos health checks is not possible since by default it listens on localhost and there is no change to now docker IP in advance to set it via flag.

Note: removal does not change previous behavior but rather improves it.

Theaxiom commented 7 years ago

Can we get current master ff'd into this branch before we merge?

ernestas-poskus commented 6 years ago

@Theaxiom rebased

Theaxiom commented 6 years ago

Thank you!