Closed jamespanton93 closed 10 months ago
Looks good, @jamespanton93. I'm happy to merge without, but it would be good to get some docs on this as well. I guess a sample model file at low resolution would also be good for the layer things. Without that it's a bit hard to test locally anyway.
Looking a bit more, I think this still needs tests for the layer file IO and tests generally for the TerraModelLayer
class.
I've converted this to a draft due to the above and once it's ready (i.e., has tests, and example files have been uploaded) we can finish it off.
@andreww How can I get an example layer file added to the figshare?
@jamespanton93 - I 'own' the figshare dataset, so you'll need to give me access to the file and I'll upload it. Otherwise you could create your own dataset, add it there, and add the resulting doi to the module with the example handling functions in. In either case, you'll need to modify that file.
Looking good—thanks!
I fixed a couple of minor things.
Could we maybe add something to the website docs? I guess the layer file format needs specifying in docs/file_formats.md
and a mention of the TerraModelLayer
class in docs/model.md
. If you want to do that in a separate PR, that's okay, or pull in my changes and update this one.
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable.
Adding routine for converting 'old' layer files into 'new' ones which include a depth dimension. Add TerraModelLayer subclass
Before your first pull request:
For all pull requests:
contrib/utilities/indent
script from the main directory to indent my code.For new features/models or changes of existing features: