mantle-convection-constrained / terratools

Tools to read, analyse and visualise models written by the TERRA mantle convection code
https://terratools.readthedocs.io/en/latest/
MIT License
7 stars 5 forks source link

Jw/examples #126

Closed eejwa closed 1 year ago

eejwa commented 1 year ago

PR notes

This pull request implements the following:

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

anowacki commented 1 year ago

Looks like the docs build script needs to install cartopy for the example script to get built.

anowacki commented 1 year ago

Also in the docs build logs:

INFO    -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
  - SeismicLookupTable.md
  - copy_ref_examples.py
  - gen_ref_pages.py

This means you need to add the page to mkdocs.yml file under the nav section for the lookup table page to appear on the website.

eejwa commented 1 year ago

Okay no problem, thanks for the help Andy!

anowacki commented 1 year ago

@eejwa feel free to merge if you're happy. All looks good.

anowacki commented 1 year ago

Closes #128.

eejwa commented 1 year ago

Brilliant, thank you for the help Andy!