Closed jamespanton93 closed 5 months ago
Great! Good to see this.
Just to note that there are breaking changes in here, so before making the next release we should either:
I'm fairly relaxed about either.
These also need items in the changelog.
Thanks Andy, I think I prefer the backwards compatible option - I will make a new PR with the relevant changes. I would also include #153 in the next release, this is also a new feature.
In this PR, which relates to #115 , I have added the ability to pass in figure and axis handles into some of the plotting routines, namely
plot_layer
,plot_section
,plot_spectral_heterogeneity
andplot_hp_map
. I have also made these functions return the handle to the colorbar to allow greater flexibility to users when producing figures. As such calls to these plotting functions in tests and examples have been updated in this PR.Before your first pull request:
For all pull requests:
contrib/utilities/indent
script from the main directory to indent my code.For new features/models or changes of existing features: