search

mantoni / mocaccino.js

Mocha test runner as a Browserify plugin
MIT License
22 stars 12 forks source link

question: overwriting Base.symbols.dot #26

Open boneskull opened 5 years ago

boneskull commented 5 years ago

Here: https://github.com/mantoni/mocaccino.js/blob/master/lib/setup-browser.js#L14

and here: https://github.com/mantoni/mocaccino.js/blob/master/lib/setup-node.js#L12

Mocaccino overwrites Base.symbols.dot. Why?

mantoni commented 5 years ago

Because IE 11 somehow managed to show an empty dot report with the mocha default character. I’d be happy to remove this if there’s a better option.

boneskull commented 5 years ago

That's probably better addressed by Mocha. But we don't test the dot reporter in the browser (until I started messing with it, anyway), so not surprised I'd never heard of this.

mantoni commented 5 years ago

I tried to find the original issue but no luck, also not in Mochify. It’s been like this for a long time. It might have been a PhantomJS related issue that’s completely obsolete. I can run some tests tomorrow.

boneskull commented 5 years ago

I can work around it for now by changing the value of dot in our tests. no rush.

mantoni commented 5 years ago

I ran some checks and cannot find any issues anymore. Works fine in IE 11 and Edge without overriding the symbol. Feel free to remove.