search

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Implement --browser-field option #139

Closed hakatashi closed 8 years ago

hakatashi commented 8 years ago

This is follow-up of #136.

As specified in https://github.com/mantoni/mochify.js/pull/136#issuecomment-214792372, I created fixtures to test against the case where the browser field of test's dependency is involved in the test code. It's located in test/fixture/browser-field.

mantoni commented 8 years ago

Thanks for the pull request and sorry for letting you wait. Nice change, nothing to complain about :balloon:. Can you rebase the commits and sqash them down to one or two? Then I'll merge and cut a release.

For bonus points you could add the new option to the readme and the help.txt.

hakatashi commented 8 years ago

@mantoni Everything is ready now :wink:

mantoni commented 8 years ago

Released in 2.18.0. Thank you!