search

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Add option to pass viewport sizing to PhantomJS #152

Closed m90 closed 7 years ago

m90 commented 7 years ago

Would solve #97

I made one mistake when doing the changes for that in phantomic though, so we might want to fix this first? Will comment inline.

mantoni commented 7 years ago

Released in v3.2.0 🎉

I just noticed that we both forgot about the help.txt file which should list the new options also ... it's getting a bit longish now ... 🤔

Another thing that came to mind, maybe for later: It would be cool to default the viewport values with the current actual console size – should we detect that we're running in a tty.

m90 commented 7 years ago

True that, I guess completeness trumps brevity so I will fix the help.txt real quick.

About the tty: cool idea, might be well worth opening an issue.