mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Option to pass additional arguments to chrome #162

Closed fearphage closed 6 years ago

fearphage commented 6 years ago

I'm running mochify as the root user in docker. Chrome needs special flags to allow it to run as root. It would be convenient if I could pass those in myself.

I was picturing this taking one of two forms:

mantoni commented 6 years ago

Thanks for looking into this. Great help 👍

Maybe we could as well add those args by default. I don't see how they're causing any problems in the context of a test runner. What do you think?

fearphage commented 6 years ago

There are security implications. I don't believe you want these to be default options. They should be opt-in.