search

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Add note about required flags in CircleCI #189

Closed m90 closed 5 years ago

m90 commented 5 years ago

I found that with v6 all of my CircleCI builds using mochify would suddenly stop running and instead timeout showing:

(node:173) UnhandledPromiseRejectionWarning: Error: Protocol error (Page.enable): Target closed.
    at Promise (/home/circleci/repo/node_modules/puppeteer/lib/Connection.js:186:56)
    at new Promise (<anonymous>)
    at CDPSession.send (/home/circleci/repo/node_modules/puppeteer/lib/Connection.js:185:12)
    at Function.create (/home/circleci/repo/node_modules/puppeteer/lib/Page.js:44:18)
    at _pagePromise._sessionFactory.then.client (/home/circleci/repo/node_modules/puppeteer/lib/Target.js:43:32)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

which seems to be due to no --allow-chrome-as-root flag being passed (which I didn't have to do in v5, but that probably happened with the Puppeteer update).

This just adds a note to the README, making the existing section not only about Travis.

mantoni commented 5 years ago

Thank you!