search

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Update puppeteer dependency #228

Closed albertyw closed 3 years ago

albertyw commented 3 years ago

This PR updates puppeteer from ^9.1.1 to ^10.0.0. This was done on top of #227 and split from #226.

This PR was generated by

  1. checking out master
  2. npm install (getting to #227)
  3. Updating package.json with the new puppeteer version
  4. npm install
m90 commented 3 years ago

@mantoni Do you think this is safe to merge? Considering npm audit on Mochify currently has a clean sheet and this brings no extra feature we need I'd maybe play safe (i.e. defer the update) but then again I might be getting too conservative lately.

mantoni commented 3 years ago

I guess it's fine. If you have doubts regarding compatibility, this could be a major. But I don't think it breaks anything from a mochify user perspective.

m90 commented 3 years ago

Ok, then let's merge it and release as 8.1.0 - I just spend way too much time wrestling $NPM_MONSTROSITY at $DAYJOB recently...

@albertyw Could you rebase the branch so it's in a mergeable state again and then we'll ship it?

albertyw commented 3 years ago

👍 Rebased

m90 commented 3 years ago

Published in 8.1.0, thank you :pray: