Allow to define "spec" in config and fix package.json

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver

MIT License

346 stars 57 forks source link

Allow to define "spec" in config and fix package.json #243

Closed mantoni closed 3 years ago

mantoni commented 3 years ago

The cli was missing the bin config.
The playwright and puppeteer drivers where missing index.html in the files array.
It wasn't possible to declare files to include in a config file. Mocha allows to define spec, which is what mochify supports now as well.

mantoni commented 3 years ago

Sorry for not waiting for the review. I'm trying to use this in @sinonjs/fake-timers to fix a long pending issue with webdriver tests there, and I fear I won't have much time for this in the next couple of days.

m90 commented 3 years ago

Sorry for not waiting for the review.

Sorry for not catching things like a missing bin in the review I guess :facepalm:

I just tried applying the new version to a project of mine and couldn't get it to work as the setup relies on a custom Chrome installation inside of a Docker container. I currently cannot pass any options to driver-puppeteer so I can't get it to work. Looking into how to fix it I wasn't entirely sure what's the best way forward:

Should consumers be able to pass through all of puppeteer's launchOptions
Should the driver selectively allow and pass certain options?

mantoni commented 3 years ago

The _retain folder still has the old chromium implementation. You can check how it was done there. I noticed the same with GitHub actions that already have a chrome bin installed.

mantoni commented 3 years ago

Should consumers be able to pass through all of puppeteer's launchOptions

On the one hand, why not? On the other hand, there are quite a few unintuitive settings.

Should the driver selectively allow and pass certain options?

We could provide sensible default settings for the testing scenario and then allow users to override those settings with any options they want.